fix: fixes invalid libc symbols on horizon-os/n3ds#653
Merged
Thomasdezeeuw merged 3 commits intorust-lang:masterfrom May 4, 2026
Merged
fix: fixes invalid libc symbols on horizon-os/n3ds#653Thomasdezeeuw merged 3 commits intorust-lang:masterfrom
Thomasdezeeuw merged 3 commits intorust-lang:masterfrom
Conversation
Collaborator
Thomasdezeeuw
left a comment
Thomasdezeeuw
left a comment
There was a problem hiding this comment.
Mostly LGTM, couple of small changes requested.
Could you also add a check to the CI here:
socket2/.github/workflows/main.yml
Line 67 in 602e784
Contributor
Author
|
Latest commit fixes all the polish work! Seems like it made the docs build fail, though, so also fixing that real quick :) |
Contributor
Author
|
And docs build fixed! Thanks for the review :) |
Thomasdezeeuw
approved these changes
May 4, 2026
Collaborator
|
Thanks @kore-signet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HorizonOS (as used on the Nintendo 3DS) doesn't support all the calls/features currently expected. This PR just configures them all out, same as is done on wasi/espidf/redox.